fix(1255): Integrated the AWS costexplorer API #1278
Conversation
… sqs, cloudfront, eks, elasticahce, redshift
tanbirali
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub,
Traxmaxx,
Azanul and
jakepage91
as code owners
|
Good work @tanbirali! It'd be great if you could implement the other ones also, if not then this PR looks GTG |
|
I will be happy to contribute more |
|
Thanks @tanbirali ! Much appreciated |
Co-authored-by: Azanul Haque <42029519+Azanul@users.noreply.github.com>
…anbirali/komiser into integrate-aws-costexplorer-api
There was a problem hiding this comment.
Hey there @tanbirali , it looks like a lot of the service names do not follow the same naming returned by the costexplorer api, here is an snippet of the return
{
"DimensionValues": [
{
"Value": "AWS CloudTrail",
"Attributes": {}
},
{
"Value": "AWS Config",
"Attributes": {}
},
{
"Value": "AWS Cost Explorer",
"Attributes": {}
},
{
"Value": "AWS Data Transfer",
"Attributes": {}
},
{
"Value": "AWS Glue",
"Attributes": {}
},
{
"Value": "AWS Key Management Service",
"Attributes": {}
},
{
"Value": "AWS Lambda",
"Attributes": {}
},
{
"Value": "AWS Migration Hub Refactor Spaces",
"Attributes": {}
},
{
"Value": "AWS Secrets Manager",
"Attributes": {}
},
{
"Value": "AWS Service Catalog",
"Attributes": {}
},
{
"Value": "AWS Step Functions",
"Attributes": {}
},
Now, it might be the case that you have tested this already and the current service names work and actually return the service level cost metrics, could you confirm that to be the case? or else could you please change the names to the aws ce get-dimension-values call.
|
I have made the changes of every aws services that I could find in that text file that contained the proper service name. But there are some services whose name were not present like for s3, codebuild, codedeploy etc. Let me if I need to make changes there. |
S3 = "Amazon Simple Storage Service" I think these will work and if not we can use |
Problem
There are few AWS Services that are pending integration
Solution
Filter out the correct resource and add to metdata field
Changes Made
User the GetCostAndUsage to extract the cost and then added it to the metadata for the following services API for ec2, ecs, iam, s3, sqs, cloudfront, eks, elasticahce, redshift
How to Test
[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]
Reviewers
@Azanul